Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Release artifacts job: binaries and containers #523

Merged
merged 5 commits into from
May 11, 2024
Merged

Conversation

okdas
Copy link
Member

@okdas okdas commented May 9, 2024

Summary

Provides binaries for releases and production-ready container images.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Documentation changes (only if making doc changes)

  • make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added push-image CI related - pushes images to ghcr.io devnet devnet-test-e2e infra Infra or tooling related improvements, additions or fixes tooling Tooling - CLI, scripts, helpers, off-chain, etc... labels May 9, 2024
Copy link

github-actions bot commented May 9, 2024

The image is going to be pushed after the next commit. You can use make trigger_ci to push an empty commit. If you also want to run an E2E test, please add devnet-test-e2e label.

Copy link

github-actions bot commented May 9, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

@okdas okdas added this to the Shannon Private TestNet milestone May 9, 2024
@okdas okdas marked this pull request as ready for review May 9, 2024 22:05
on:
push:
tags:
- "v*.*.*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on the push trigger, but we don't have a good way to test the release creation from tag. Let's create the first tag after this is merged to test this CI job fully.

@okdas okdas requested a review from Olshansk May 10, 2024 00:59
@okdas
Copy link
Member Author

okdas commented May 10, 2024

@Olshansk Upgrade to 1.22 was important for integration with the heighliner. I put the integration on pause, but I kept the upgraded version since I don't see any reason not to — Golang has great backwards compatibility and all tests seem to pass fine.

@okdas okdas self-assigned this May 10, 2024
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one non-blocking question!


USER pocket

ENTRYPOINT ["poktrolld"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the poktrolld binary the entrpoint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the poktrolld binary the entrpoint?

glad you asked.

It allows to easy set up a shell alias to use poktrolld from docker without installing the binary on the machine. I'll showcase this in the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#PUC

# poktrolld is the entrypoint to allow easily setting up a shell alias to use poktrolld from docker without installing the binary on the machine. I'll showcase this in the docs.
ENTRYPOINT ["poktrolld"]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okdas ☝️

@okdas okdas merged commit 17fe926 into main May 11, 2024
9 checks passed
bryanchriswhite added a commit that referenced this pull request May 13, 2024
* pokt/main:
  [CI] Release artifacts job: binaries and containers (#523)
bryanchriswhite added a commit that referenced this pull request May 13, 2024
…cept

* pokt/main:
  [CI] Release artifacts job: binaries and containers (#523)
@bryanchriswhite bryanchriswhite removed push-image CI related - pushes images to ghcr.io devnet-test-e2e labels May 16, 2024
@github-actions github-actions bot removed the devnet label May 16, 2024
@Olshansk Olshansk deleted the dk-release-artifacts branch May 29, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra or tooling related improvements, additions or fixes tooling Tooling - CLI, scripts, helpers, off-chain, etc...
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants